JianyuWang0623 commented on code in PR #2737: URL: https://github.com/apache/nuttx-apps/pull/2737#discussion_r1808100438
########## nshlib/nsh_parse.c: ########## @@ -2658,12 +2658,12 @@ static int nsh_parse_command(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline) int argc; int ret = ERROR; bool redirect_out_save = false; - bool redirect_in_save = false; - size_t redirect_out1_len = strlen(g_redirect_out1); - size_t redirect_out2_len = strlen(g_redirect_out2); - size_t redirect_in1_len = strlen(g_redirect_in1); + bool redirect_in_save = false; + size_t redirect_out1_len = sizeof(g_redirect_out1) - 1; Review Comment: > change to global const done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
