xiaoxiang781216 commented on code in PR #14595:
URL: https://github.com/apache/nuttx/pull/14595#discussion_r1825967169


##########
include/sys/socket.h:
##########
@@ -327,7 +327,7 @@ struct sockaddr_storage
 
   /* Following fields are implementation-defined */
 
-  struct
+  struct __attribute__((packed))

Review Comment:
   > @xiaoxiang781216 I'm already running the Mirrored Builds twice every day, 
why don't we use it? https://github.com/NuttX/nuttx/actions/runs/11630100298
   > 
   > @nuttxs To verify the Windows Build on your own NuttX Repo, please follow 
the steps in "To Run Windows Jobs" thanks!
   > 
   > * [[Guide] How to Verify a PR MergeĀ 
#14407](https://github.com/apache/nuttx/issues/14407)
   
   But it's too late, it's better to catch the error before merging. Please 
restore one macOS, Windows and msys2 to ci  if we have the free quota. If no 
free quota is available, it's better to remove some Ubuntu ARM build from CI to 
bring back them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to