nuttxs commented on code in PR #14595:
URL: https://github.com/apache/nuttx/pull/14595#discussion_r1826957934


##########
include/sys/socket.h:
##########
@@ -327,7 +327,7 @@ struct sockaddr_storage
 
   /* Following fields are implementation-defined */
 
-  struct
+  struct __attribute__((packed))

Review Comment:
   @xiaoxiang781216 
   My apologies for the late response. I noticed that you have already 
submitted a pull request 
([PR#14608](https://github.com/apache/nuttx/pull/14608)) addressing the 
compatibility of `__attribute__((packed)) f`or MSVC.
   
   By the way, does MSVC support the **`__attribute__((aligned(n)))`** 
attribute or keyword? I couldn't find the corresponding definition in 
compiler.h, and Nuttx makes extensive use of **`__attribute__((aligned(n)))`** 
for alignment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to