nuttxpr commented on PR #14687: URL: https://github.com/apache/nuttx/pull/14687#issuecomment-2461805182
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not meet the NuttX requirements. While it provides the template, it lacks the crucial information required by the template. Specifically, the sections marked with "*Update this section...*" are placeholders and haven't been filled with the actual details of the change. A PR with these placeholders is incomplete and unreviewable. Here's a breakdown of what's missing: * **Summary:** The summary needs to explain the *why*, *what*, and *how* of the change. It mentions a trdc header for the imx9-evk bootloader, but doesn't explain *why* this header is needed, *what* it contains, or *how* it solves the problem. There's no mention of related issues. * **Impact:** All the impact fields are left blank. The author needs to assess and document the impact of the change on users, build process, hardware, documentation, security, and compatibility. * **Testing:** The testing section is also incomplete. It requests details about the build host and target, as well as logs from before and after the change, but none of this information is provided. Simply stating "This is needed" isn't sufficient verification. To meet the NuttX requirements, the author needs to fill out all the required sections with specific information relevant to the changes made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
