JianyuWang0623 commented on code in PR #14709: URL: https://github.com/apache/nuttx/pull/14709#discussion_r1835720507
########## tools/rp2040/Config.mk: ########## @@ -26,17 +26,36 @@ # POSTBUILD -- Perform post build operations -ifeq ($(CONFIG_RP2040_UF2_BINARY),y) -ifdef PICO_SDK_PATH -define POSTBUILD - $(Q)echo "Generating: nuttx.uf2"; \ +PICOTOOL_BUILD_TEMP?=build_picotool Review Comment: Done. ########## tools/rp2040/Config.mk: ########## @@ -26,17 +26,36 @@ # POSTBUILD -- Perform post build operations -ifeq ($(CONFIG_RP2040_UF2_BINARY),y) -ifdef PICO_SDK_PATH -define POSTBUILD - $(Q)echo "Generating: nuttx.uf2"; \ +PICOTOOL_BUILD_TEMP?=build_picotool +PICOTOOL_BUILD_PATH?=$(PICO_SDK_PATH)$(DELIM)$(PICOTOOL_BUILD_TEMP) Review Comment: > why not build inplace? Currently already build in pico-sdk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
