xiaoxiang781216 commented on code in PR #14695:
URL: https://github.com/apache/nuttx/pull/14695#discussion_r1836177287
##########
drivers/syslog/Kconfig:
##########
@@ -267,19 +267,25 @@ config SYSLOG_STREAM
config SYSLOG_CONSOLE
bool "Log to /dev/console"
- default !ARCH_LOWPUTC && !SYSLOG_CHAR && !RAMLOG_SYSLOG &&
!SYSLOG_RPMSG && !SYSLOG_RTT
+ default !SYSLOG_CHAR && !RAMLOG_SYSLOG && !SYSLOG_RPMSG && !SYSLOG_RTT
Review Comment:
> > We don't hit the deadlock since the driver already do the protection.
>
> which driver are you talking about? you have a fix in your local tree, you
mean? or, in up_putc implementation for your target? (which target is it?)
>
Yes, it's in the local tree, since the chip vendor doesn't want to upstream
their code to community.
> > Yes, I can change to ramlog in my defconfig, and you can change to
console in your defconfig too, but you can't change the default setting in
master branch since all defconfig expect syslog can be called from
panic/assert/interrupt.
>
> IMO, the default should be something safe.
it depends on the context: SMP safe or interrupt safe. Since the default
config is interrupt safe for a long time ago, we need keep this default
behavior. So, I suggest making console syslog work in the interrupt context,
which isn't hard to do, so we can switch to it and remove default syslog
channel directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
