raiden00pl commented on code in PR #14695:
URL: https://github.com/apache/nuttx/pull/14695#discussion_r1836129416
##########
drivers/syslog/Kconfig:
##########
@@ -267,19 +267,25 @@ config SYSLOG_STREAM
config SYSLOG_CONSOLE
bool "Log to /dev/console"
- default !ARCH_LOWPUTC && !SYSLOG_CHAR && !RAMLOG_SYSLOG &&
!SYSLOG_RPMSG && !SYSLOG_RTT
+ default !SYSLOG_CHAR && !RAMLOG_SYSLOG && !SYSLOG_RPMSG && !SYSLOG_RTT
Review Comment:
> this PR just disables a functionality which is broken. (just because
leaving it enabled hurts users. i received complaints from users.)
if you want to use it and you don't care the breakage, you can still enable
it.
With this change you will have other users complaining why logging from
interrupts doesn't work by default. Satisfying some users at the expense of
others is not the solution, especially considering that there are more
platform without SMP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
