pussuw commented on code in PR #14859:
URL: https://github.com/apache/nuttx/pull/14859#discussion_r1849548698


##########
sched/addrenv/addrenv.c:
##########
@@ -400,9 +401,7 @@ int addrenv_restore(FAR struct addrenv_s *addrenv)
 
 void addrenv_take(FAR struct addrenv_s *addrenv)
 {
-  irqstate_t flags = enter_critical_section();
-  addrenv->refs++;

Review Comment:
   The type of refs should not be the issue here as ordering should be 
guaranteed by atomic_fetch_add.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to