Ouss4 commented on a change in pull request #1369: URL: https://github.com/apache/incubator-nuttx/pull/1369#discussion_r452536120
########## File path: arch/arm/src/arm/arm_initialstate.c ########## @@ -52,13 +52,7 @@ * Pre-processor Definitions ****************************************************************************/ -/**************************************************************************** - * Private Data - ****************************************************************************/ - -/**************************************************************************** - * Private Functions - ****************************************************************************/ +#define IDLETHREAD_STACKMARGIN 128 Review comment: > This margin think could bite us. @davids5 wasn't a margin already there: `"\tmov r1, r1, lsr #2\n" /* R1 = nwords = nbytes >> 2 */` With the latest change the margin is the same as the above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org