xucheng5 commented on PR #14759: URL: https://github.com/apache/nuttx/pull/14759#issuecomment-2496530339
> @xucheng5 I think it should be flexible enough to let some less common usage scenarios: i.e.: it could be possible to use the internal CAN peripheral from a MCU with SocketCAN and an external MCP2515 with CAN char dev. Using global variables shared by both will introduce issues to this case of use. I think your modifications are fine, but we need to test these usage case to confirm everything still working fine. The conversion of DLC into byte length/ byte length into DLC does not care about socketcan or character-can, which is the processing of CAN protocol. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
