w8jcik opened a new pull request #334:
URL: https://github.com/apache/incubator-nuttx-apps/pull/334
## Summary
LittlevGL is an example of library that copies it's header outside of it's
folder.
This PR removes this behavior, so the library exposes one of it's folders as
include directory.
LittlevGL is just an example and this PR is proof of concept if you accept
such change.
## Impact
Applications are not separable because they have some files outside of their
folders. In particular LittlevGL is copying `lvgl.h` to
`include/graphics/lvgl.h` when building. This file organisation doesn't seem to
help with anything. If someone finds it useful to have one `include` directory
with all possible libraries it also doesn't work because normally `lvgl.h`
header is not there.
If this change accepted I can change the other applications to be like this.
Long term purpose of this is to be able to plug-in and out libraries.
(package management)
## Testing
```
mkdir test
(
cd test
git clone https://github.com/apache/incubator-nuttx.git
git clone https://github.com/apache/incubator-nuttx-apps.git
(
cd nuttx
tools/configure.sh stm32f4discovery/nsh
make menuconfig
# enable GRAPHICS_LVGL and EXAMPLES_LVGLDEMO
(http://nuttx-config-dev.nxtlabs.pl/#/?filter=LVGL)
make -j 12
)
)
```
It is just bulid system change and it builds. Also if anything is wrong with
`apps/graphics/lvgl`, the `apps/examples/lvgldemo` fails to bulid which shows
that one is using the other. I didn't run it on a board.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
