w8jcik commented on a change in pull request #334:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/334#discussion_r455103797
##########
File path: graphics/lvgl/Makefile
##########
@@ -78,20 +78,21 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL)
$(Q) mv lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME)
$(Q) touch $(LVGL_UNPACKNAME)
-lvgl/lvgl.h: $(LVGL_UNPACKNAME)
+$(LVGL_UNPACKNAME)/lvgl.h: $(LVGL_UNPACKNAME)
-$(APPDIR)/include/graphics/lvgl.h: lvgl/lvgl.h
- @echo "CP: lvgl/lvgl.h"
- $(Q) cp lvgl/lvgl.h $(APPDIR)/include/graphics/lvgl.h
+exports/graphics/lvgl.h: $(LVGL_UNPACKNAME)/lvgl.h
+ $(Q) mkdir -p exports/graphics
+ @echo "CP: $(LVGL_UNPACKNAME)/lvgl.h"
+ $(Q) cp $(LVGL_UNPACKNAME)/lvgl.h exports/graphics/lvgl.h
Review comment:
Sure, but then we need to `#include <lvgl.h>` instead of `#include
<graphics/lvgl.h>`. I don't mind but I though that this prefix is intentional
to keep things within namespaces like `graphics` here. Do we want to keep
prefixes or do they go? So far they were used consistently.
Here is additional PR which shows necessary change to introduce this
suggestion https://github.com/w8jcik/incubator-nuttx-apps/pull/1/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
