raiden00pl commented on PR #11428: URL: https://github.com/apache/nuttx/pull/11428#issuecomment-2536437873
> Also, please note that the struct rmt_ops_s (at include/nuttx/rmt/rmt.h) isn't part of the upper-half generic RMT driver (nuttx/include/nuttx/rmt/rmtchar.h. I agree that the location of the rmt.h file could be understood like that (and should eventually be moved to the arch folder, although it is used by more than a arch) My reasoning is that if it's in the common driver headers (`include/nuttx/rmt`), then it's upper-half part. So here is our difference :) RMT upper-half itself seems to be wrong, as it's architecture specific driver. ESP architecture logic should implement `RMT_COMMON` and then based on `RMT_COMMON` there should be lower-half implementation for `rc/lirc_dev.c` and `WS2818_UPPER`. Currently we have 2 drivers implementing IR driver that are incompatible with each other, which means there is no way to have a portable architecture between different vendors. Especially when `drivers/rc` was already upstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
