raiden00pl commented on PR #11428: URL: https://github.com/apache/nuttx/pull/11428#issuecomment-2539783344
> Let's avoid using RMT generically. I suppose you didn't mean to move drivers/rmt/rmtchar.c to arch folder, right? It's clearly an upper-half driver and totally optional. It's just an interface to the lower-half. If you want to stick with RMT character driver then yes, I mean to move it to `arch/` folder. You can grep `arch/` for `register_driver` and you can see that there is nothing wrong with upper-half arch-specific implementations in `arch/`. > And I just said that it isn't architecture specific. It's vendor-specific (at least for now), not arch-specific. We can argue whether it's arch-specific or vendor-specific. This doesn't make sense to me, since both should be placed in `arch/`. We have here similar case as the `HRTIM` I mentioned earlier and the solution should be the same. > There is a difference between the good and the needed. Again, this approach is against `INVIOLABLES.md`, but I understand that we are all busy and don't have time to do everything we would like to. In that case I propose to create an issue to not forget about this problem and in the future avoid vendor/arch specific drivers in `drivers/` if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
