jlaitine opened a new pull request, #15259: URL: https://github.com/apache/nuttx/pull/15259
Don't fail if the lowerhalf mtd driver doesn't support BIOC_FLUSH; This is normal - if the lowerhalf has nothing to do, it doesn't handle the IOCTL. ## Summary "fsync" broke for all the existing mtd lowerhalf drivers in 521b3bb500e0652d90995cb32a08f0d5fb262256, since none of the lowerhalf drivers supports BIOC_FLUSH. This means that every BIOC_FLUSH to bchdev now fails with "-ENOTTY". This PR tries to fix the issue by checking if the lowerhalf driver actually supports the IOCTL - keeping the change where BIOC_FLUSH is also passed to the lower half device. An alternative solution for the issue would be simply reverting the original patch - as BIOC_FLUSH is not supported by any mtd lowerhalf, the change doesn't bring any value (at least for the upstream nuttx), and just breaks bchdev for every user. ## Impact Fixes BIOC_FLUSH for bch+mtd, which is currently broken for e.g. at24 devices (and all the others as well). ## Testing Tested on at24 eeprom on mpfs and imx9 platforms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
