nuttxpr commented on PR #15259: URL: https://github.com/apache/nuttx/pull/15259#issuecomment-2550735182
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** fully meet the NuttX requirements. While it provides a reasonable summary and explains the impact, it is severely lacking in the Testing section. Here's a breakdown: * **Missing Information in Summary:** While the summary explains the problem and solution, it lacks a direct link to the related NuttX issue (if one exists). This is crucial for traceability and context. * **Impact Section is Insufficient:** While it mentions fixing `BIOC_FLUSH`, it doesn't explicitly address all the required points. It needs to clearly state YES/NO for each impact category (user, build, hardware, documentation, security, compatibility) with explanations where applicable. For example, even if the answer is NO, it should explicitly state "Impact on build: NO". * **Testing Section is Inadequate:** This is the biggest problem. Simply stating "Tested on at24 eeprom on mpfs and imx9 platforms" is not enough. The requirements specifically ask for: * **Build Host Details:** OS, CPU architecture, compiler version. * **Target Details:** Architecture (simulated or real hardware), board and configuration. * **Logs Before the Change:** Demonstrating the failure. * **Logs After the Change:** Showing the fix in action. Without these details, it's impossible to verify the effectiveness of the proposed fix and reproduce the testing. **How to Improve the PR:** 1. **Add the NuttX issue link to the Summary.** 2. **Expand the Impact section:** Address all impact categories with YES/NO and provide explanations where necessary. Even if there's no impact, explicitly state "NO". Example for "Impact on build": "Impact on build: NO. The build process remains unchanged." 3. **Provide Detailed Testing Information:** Include the requested host and target details. Crucially, include the "before" and "after" logs demonstrating the issue and the fix. The logs should clearly show the error occurring before the change and the correct behavior after the change. By addressing these points, the PR will be much stronger and more likely to be accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
