nuttxpr commented on PR #15454: URL: https://github.com/apache/nuttx/pull/15454#issuecomment-2575061772
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a brief summary of the *what*, it lacks crucial information regarding the *why*. The impact section is insufficient, simply stating "none" without addressing any of the specific points required. The testing section is completely empty. Here's what's missing and needs to be addressed: * **Summary:** *Why* are spaces being removed and tabs added? What problem does this solve? What part of the code is affected (e.g., all Kconfig files, specific subsystems)? How exactly does the change work (e.g., automated script, manual editing)? Are there related issues? * **Impact:** While the changes might seem trivial, they could still have an impact. Consider: * **Impact on build:** Will the build system interpret tabs differently? Are there any potential issues with different editors or IDEs handling tabs vs. spaces? * **Impact on documentation:** If coding style guidelines exist, do these changes require updates to the documentation? * **Impact on compatibility:** Will existing user configurations be affected? * **Testing:** Provide clear evidence that the changes work as intended. This includes specifying the build host and target environments used for testing and providing *actual* testing logs before and after the change. Even a simple build log demonstrating successful compilation before and after the change would be a significant improvement. Ideally, demonstrate that the kernel configures and runs correctly after the change. Without this information, it's impossible to properly review the PR and assess its suitability for inclusion in NuttX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
