hujun260 commented on code in PR #15506:
URL: https://github.com/apache/nuttx/pull/15506#discussion_r1914035825


##########
arch/arm/src/cxd56xx/cxd56_usbdev.c:
##########
@@ -2269,10 +2289,10 @@ static int cxd56_epdisable(struct usbdev_ep_s *ep)
 
   /* Cancel any ongoing activity and reset the endpoint */
 
-  flags = enter_critical_section();
+  flags = spin_lock_irqsave(&privep->ep.lock);
   cxd56_epstall(&privep->ep, false);

Review Comment:
   cxd56_epstall may call  usbtrace and case context_switch.
   please check all place!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to