wangzhi-art commented on code in PR #15546: URL: https://github.com/apache/nuttx/pull/15546#discussion_r1915900668
########## arch/renesas/src/rx65n/rx65n_usbdev.c: ########## @@ -2998,10 +3004,12 @@ static int rx65n_epdisable(struct usbdev_ep_s *ep) /* Cancel any ongoing activity */ - flags = enter_critical_section(); + flags = spin_lock_irqsave(&g_usbdev.lock); Review Comment: Because there is only one usbdev instance, g_usbdev.lock, priv->lock, and privep->dev->lock all represent the same lock. I think it would be better to unify the names, so g_usbdev.lock is used here. Do I need to change it to priv->lock and privep->dev->lock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
