michallenc commented on code in PR #15812:
URL: https://github.com/apache/nuttx/pull/15812#discussion_r1950912832


##########
drivers/mtd/w25qxxxjv.c:
##########
@@ -976,10 +976,10 @@ static int w25qxxxjv_erase_sector(FAR struct 
w25qxxxjv_dev_s *priv,
     }
 
   status = w25qxxxjv_read_status(priv);
-  if ((status & STATUS_BUSY_MASK) != STATUS_READY)
+  while ((status & STATUS_BUSY_MASK) != STATUS_READY)

Review Comment:
   @acassis Probably yes. The advantage is we know the longest possible delay 
(entire flash erase time), so I put a counter there with this time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to