cederom commented on PR #15812: URL: https://github.com/apache/nuttx/pull/15812#issuecomment-2655376910
> @cederom: @anchao did you see there is ongoing discussion in progress before you merged? > @anchao: I saw @acassis approved this PR, this is a valid response Okay, I will mark "changes requested" each time I have questions. > @anchao: IMHO that maintainers should spend more time on reading and learning code and software architecture instead of commenting, which will make it more efficient. Nuttx is already a very big project. If the pressure is put on contributors blindly, then the management method of this project is problematic. @anchao so after reading the code you saw that not only return fix is there but also introduction of new blocking behavior with arbitrary delay with no polling for success and still may return error on incomplete operation and you are okay with that? I know this is the simplest possible implementation, just wanted to make sure we are aware of the risks. Its not that I don't understand the code change, questions are asked simple way so everyone that comes in understands what is the problem and context ;-) Recent discussions on mailing lists reveal the problem we have is not with blind pressuring the contributors, quite the opposite, blind pushing and merging insufficiently validated breaking changes. We are trying to fix that, maybe it will work, maybe not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
