LuchianMihai commented on code in PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#discussion_r1959996001


##########
tools/espressif/check_esptool.py:
##########
@@ -56,28 +46,24 @@ def parse_version(version_string) -> list:
 
 
 def check_version(min_esptool_version: str) -> int:

Review Comment:
   ```suggestion
   def check_version(min_esptool_version: str) -> bool:
   ```
   Function returns Trure/False, but it has int as return type hint.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to