fdcavalcanti opened a new pull request, #15915:
URL: https://github.com/apache/nuttx/pull/15915

   ## Summary
   
   Fix print statement for uint8 and uint16 types.
   Required due to efforts on fixing #15755 .
   
   I had recently sent a PR on this same driver but missed a couple of lines.
   
   Error example:
   ```
   In file included from net/lan9250.c:34:
   net/lan9250.c: In function 'lan9250_wait_ready':
   net/lan9250.c:620:12: warning: format '%x' expects argument of type 
'unsigned int', but argument 4 has type 'uint32_t' {aka 'long unsigned int'} 
[-Wformat=]
     620 |       nerr("ERROR: wait register:0x%02x, mask:0x%08x, 
expected:0x%08x\n",
         |            
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     621 |             address, mask, expected);
         |                      ~~~~
         |                      |
         |                      uint32_t {aka long unsigned int}
   net/lan9250.c:620:52: note: format string is defined here
     620 |       nerr("ERROR: wait register:0x%02x, mask:0x%08x, 
expected:0x%08x\n",
         |                                                 ~~~^
         |                                                    |
         |                                                    unsigned int
         |                                                 %08lx
   ```
   
   
   ## Impact
   
   - Impact on user: NO.
   - Impact on build: This will throw erros when fixing 
https://github.com/apache/nuttx/issues/15755. It can be merged now since it 
won't affect current builds.
   - Impact on hardware: NO.
   - Impact on documentation: NO.
   - Impact on security: NO.
   - Impact on compatibility: NO.
   
   ## Testing
   
   This test simply builds the binary and checks for compilation errors.
   Unfortunately I don't have this device to test (requires external LAN9250). 
If someone has, please speak up!
   
   ### Building
   
   - ./tools/configure.sh esp32s3-devkit:eth_lan9250
   - make
   
   ### Results
   
   No build errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to