Re: [PR] drivers/net: update format specifier on lan9250 driver [nuttx]

[via GitHub]

cederom commented on code in PR #15915:
URL: https://github.com/apache/nuttx/pull/15915#discussion_r1976213623


##########
drivers/net/lan9250.c:
##########
@@ -736,7 +736,7 @@ static void lan9250_wait_mac_ready(FAR struct 
lan9250_driver_s *priv,
 
   if (timeout)
     {
-      nerr("ERROR: wait MAC register:0x%02" PRIx32 \
+      nerr("ERROR: wait MAC register:0x%02" PRIx8 \

Review Comment:
   ```
   static void lan9250_wait_ready(
     FAR struct lan9250_driver_s *priv,
     uint16_t address, uint32_t mask,
     uint32_t expected, uint32_t second )
   ```
   
   so should be  `0x%04"PRIx16` here too ? :-)



##########
drivers/net/lan9250.c:
##########
@@ -617,7 +617,7 @@ static void lan9250_wait_ready(FAR struct lan9250_driver_s 
*priv,
 
   if (timeout)
     {
-      nerr("ERROR: wait register:0x%02" PRIx32 \
+      nerr("ERROR: wait register:0x%02" PRIx16 \

Review Comment:
   ```
   static void lan9250_wait_ready(
     FAR struct lan9250_driver_s *priv,
     uint16_t address, uint32_t mask,
     uint32_t expected, uint32_t second )
   ```
   
   so should be  `0x%04"PRIx16` ? :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org