nuttxpr commented on PR #15937: URL: https://github.com/apache/nuttx/pull/15937#issuecomment-2696093127
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. The PR summary is insufficient. It lacks crucial details. While it states *what* was added, it omits *why* it was necessary, *how* it works, and which functional part of the code was changed (the watchdog driver?). The impact section is similarly lacking. Saying it "has no effect on original implementation" doesn't address the impact criteria. Does it consume more resources? Are there any new configuration options? The testing section is also weak. It mentions the target, but not the host build environment, and completely lacks "before" and "after" logs. It needs to show how the new functionality was tested and that it behaves as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
