Fix-Point commented on PR #15937: URL: https://github.com/apache/nuttx/pull/15937#issuecomment-2809276203
> @Fix-Point @xiaoxiang781216 > > There are 2 serious problems with `work_queue_period` in this PR: > > 1. watchdog list in work_s is reused in the callback of `work_queue_period`, which will causing the wd list of work_queue to be corrupted if period timer is expiration >  > 2. When the CPU is busy, the period worker cannot be scheduled because the period time is refreshed in the watchdog callback > > I have done a simple test in sim/nsh and found that after starting `work_queue_period`, the system crashed due to worker list corruption > > I am curious whether you have tested this PR on internal project? You are right. The question is the field reused by the queue node. I am going to make another periodic workqueue patch in a few days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
