anchao commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r1982685527
########## libs/libnx/nxfonts/CMakeLists.txt: ########## @@ -251,5 +251,12 @@ if(CONFIG_NXFONTS) add_font(tom-thumb-4x6 43) endif() + # Fix -Wshadow warnings for built-in bitops on x86_64 + + if(CONFIG_ARCH_X86_64) + list(APPEND CFLAGS -fno-builtin-ffs -fno-builtin-ffsl -fno-builtin-ffsll) + list(APPEND CFLAGS -fno-builtin-fls -fno-builtin-flsl -fno-builtin-flsll) Review Comment: Sounds good, but my concern is that the toolchain provides many of runtime/builtin functions. If each of functions needs to be handled by command line , wouldn't every architecture need to fill in these compilation options?do we have any elegant way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org