Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r2021011359
########## arch/arm/src/common/Toolchain.defs: ########## @@ -124,6 +124,11 @@ ifeq ($(CONFIG_UNWINDER_ARM),y) endif endif +# Fix -Wshadow warnings for built-in bitops on sim + +ARCHOPTIMIZATION += -fno-builtin-ffs -fno-builtin-ffsl -fno-builtin-ffsll Review Comment: It works but it would break our internal CI because there might be some third-party code like: ```c extern int ffs(int x); ``` If we use the macro implementation, it will be expands to `extern int (__builtin_ctz(j) + 1)(int x);`, causing compilation error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org