keever50 commented on issue #15856: URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2704934310
@linguini1 Merged the new things. I'm looking which added IOCTLs of you can stay or move. - WLIOC_SETBITRATE, is this for GFSK? Then lets move that under GFSK tag - WLIOC_CRCEN -> WLIOC_LORA_ENCRC - WLIOC_SETCODERATE -> WLIOC_LORA_SETCR (with an enum) - WLIOC_IQEN can stay. Good idea for common. - WLIOC_SETSYNC -> WLIOC_LORA_SYNCWORD - WLIOC_SETMOD can stay for common - WLIOC_SETSPREAD -> WLIOC_LORA_SF - WLIOC_SETBANDWIDTH -> WLIOC_LORA_BW - WLIOC_GETSNR -> in the rx_header, since its common packet specific, right? WLIOC_SETTXPOWERF is the same as WLIOC_SETTXPOWER? I think so far this is the only breaking change. I'm not entirely sure if we really need that fine precision afterall. Nearly all chips only do steps of 1dB. If we do really need it, we should probably make this fixedmath.h b16_t. Do we really need to GET the values too? Everything is usually reset after closing the driver anyway. What do you think of that? _Also Your driver has a sneaky bug in it WLIOC_GETTXPOWERF is 0x0020. You accidently incremented from 0x19 to 0x20. Should be 0x1a lol._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
