keever50 commented on issue #15856: URL: https://github.com/apache/nuttx/issues/15856#issuecomment-2706020072
@linguini1 Thanks I really love the idea of simplifying read(), so good, however @raiden00pl got a really strong point. reading rx_hdr struct might make handling easier with less errors. About the discussion of the floating, integer or fixedpoint.h. I agree. For some reason i thought we were avoiding floats all together. I would love to call it 1/100dBm, centi-dBm or 10x milli-dBm. First one is probably the best. The GET/SET. Good points, but the radios i worked with do not have hardware instructions to GET back values. So requiring the driver to keep an internal state. However, I completely understand "setting TX power may round to the next highest level the chip supports. ", which is a nice use for GET to check. It is indeed nicer to "snap" to nearest than returning errors. However that leaves room for hidden errors if you dont check GET and only error. But yeah maybe leave it in for consistency. Ill make these changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
