filippofontana commented on code in PR #12804:
URL: https://github.com/apache/nuttx/pull/12804#discussion_r2000885540


##########
arch/risc-v/src/common/Make.defs:
##########
@@ -91,6 +91,10 @@ ifeq ($(CONFIG_ARCH_RV_ISA_A),y)
 CMN_ASRCS += riscv_testset.S
 endif
 
+ifeq ($(CONFIG_ARCH_RV_HAVE_APLIC),y)
+CMN_CSRCS += riscv_aia.c

Review Comment:
   There is a difference between this `Make.defs` and the `CMakeLists.txt` 
above.
   `riscv_aia.c` doesn't exist in the source tree, doesn't this break the 
compilation with regular `make` or am I missing something? I didn't find any 
place where this file could be generated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to