keever50 commented on code in PR #16024: URL: https://github.com/apache/nuttx/pull/16024#discussion_r2005192904
########## include/nuttx/wireless/ioctl.h: ########## @@ -48,67 +48,214 @@ * the open() interface. ****************************************************************************/ -#define WLIOC_SETRADIOFREQ _WLCIOC(0x0001) /* arg: Pointer to uint32_t, */ - /* frequency value (in MHz) */ -#define WLIOC_GETRADIOFREQ _WLCIOC(0x0002) /* arg: Pointer to uint32_t, */ - /* frequency value (in MHz) */ -#define WLIOC_SETADDR _WLCIOC(0x0003) /* arg: Pointer to address value, format - * of the address is driver specific */ -#define WLIOC_GETADDR _WLCIOC(0x0004) /* arg: Pointer to address value, format - * of the address is driver specific */ -#define WLIOC_SETTXPOWER _WLCIOC(0x0005) /* arg: Pointer to int32_t, */ - /* output power (in 0.01 dBm) */ -#define WLIOC_GETTXPOWER _WLCIOC(0x0006) /* arg: Pointer to int32_t, */ - /* output power (in 0.01 dBm) */ +/**************************************************************************** + * RF common IOCTL commands + ****************************************************************************/ + +/* Offsets */ + +#define _WLIOC_COM_OFFS 1 +#define _WLIOC_COM(x) _WLCIOC(_WLIOC_COM_OFFS+x) + +/* Commands */ + +#define WLIOC_SETRADIOFREQ _WLIOC_COM(0) /* arg: Pointer to uint32_t, */ + /* frequency value (in Hz) */ +#define WLIOC_GETRADIOFREQ _WLIOC_COM(1) /* arg: Pointer to uint32_t, */ + /* frequency value (in Hz) */ + +#define WLIOC_SETADDR _WLIOC_COM(2) /* arg: Pointer to address value, format + * of the address is driver specific */ +#define WLIOC_GETADDR _WLIOC_COM(3) /* arg: Pointer to address value, format + * of the address is driver specific */ + +#define WLIOC_SETTXPOWER _WLIOC_COM(4) /* arg: Pointer to int32_t, */ + /* Set output power in dBm */ +#define WLIOC_GETTXPOWER _WLIOC_COM(5) /* arg: Pointer to int32_t, */ + /* Get output power in dBm */ + +#define WLIOC_SETFINEPOWER _WLIOC_COM(6) /* arg: Pointer to int32_t, + * Set power in steps of 0.01 dBm */ +#define WLIOC_GETFINEPOWER _WLIOC_COM(7) /* arg: Pointer to int32_t, + * Get power in steps of 0.01 dBm */ + +#define WLIOC_SETMODU _WLIOC_COM(8) /* arg: Pointer to enum wlioc_modulation_e. + * This sets the modulation technology. */ +#define WLIOC_GETMODU _WLIOC_COM(9) /* arg: Pointer to enum wlioc_modulation_e. + * Get current modulation technology. */ + Review Comment: ohno that looks indeed annoying to look at. I will fix that this evening! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
