keever50 commented on code in PR #16024: URL: https://github.com/apache/nuttx/pull/16024#discussion_r2005199938
########## include/nuttx/wireless/ioctl.h: ########## @@ -48,67 +48,214 @@ * the open() interface. ****************************************************************************/ -#define WLIOC_SETRADIOFREQ _WLCIOC(0x0001) /* arg: Pointer to uint32_t, */ - /* frequency value (in MHz) */ -#define WLIOC_GETRADIOFREQ _WLCIOC(0x0002) /* arg: Pointer to uint32_t, */ - /* frequency value (in MHz) */ -#define WLIOC_SETADDR _WLCIOC(0x0003) /* arg: Pointer to address value, format - * of the address is driver specific */ -#define WLIOC_GETADDR _WLCIOC(0x0004) /* arg: Pointer to address value, format - * of the address is driver specific */ -#define WLIOC_SETTXPOWER _WLCIOC(0x0005) /* arg: Pointer to int32_t, */ - /* output power (in 0.01 dBm) */ -#define WLIOC_GETTXPOWER _WLCIOC(0x0006) /* arg: Pointer to int32_t, */ - /* output power (in 0.01 dBm) */ +/**************************************************************************** + * RF common IOCTL commands + ****************************************************************************/ + +/* Offsets */ + +#define _WLIOC_COM_OFFS 1 Review Comment: Good catch about the FAR. That still has to get into my muscle memory. Yeah sure about the alignments. Somewhere in my mind told me that having a different alignment for this section would keep a visual separation between the commands and these irrelevant to the user offsets. But for the sake of consistency ill just align them like everything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
