acassis commented on code in PR #16241: URL: https://github.com/apache/nuttx/pull/16241#discussion_r2051792889
########## tools/Unix.mk: ########## @@ -753,6 +753,7 @@ savedefconfig: apps_preconfig $(Q) grep "^CONFIG_ARCH_CHIP_" .config >> defconfig.tmp; true $(Q) grep "CONFIG_ARCH_CHIP=" .config >> defconfig.tmp; true $(Q) grep "CONFIG_ARCH_BOARD=" .config >> defconfig.tmp; true + $(Q) grep "CONFIG_ARCH_BOARD_COMMON=" .config >> defconfig.tmp; true Review Comment: @shtirlic because this modification will include the common board to some boards that were adding it over other Kconfig, see the raspberrypi-pico-2 as example: ``` [1/1] Normalize raspberrypi-pico-2/usbnsh 16a17 > CONFIG_ARCH_BOARD_COMMON=y Saving the new configuration file HEAD detached at pull/16241/merge ``` Inside arch/arm/Kconfig, there is this rule: ``` config ARCH_CHIP_RP23XX bool "Raspberry Pi RP23XX" select ARCH_CORTEXM33 select ARCH_HAVE_RAMVECTORS select ARCH_HAVE_MULTICPU select ARCH_HAVE_I2CRESET select ARM_HAVE_WFE_SEV select ARCH_HAVE_CUSTOM_TESTSET select ARCH_HAVE_PWM_MULTICHAN select ARCH_BOARD_COMMON ``` So, ARCH_BOARD_COMMON were defined by default when the chip is RP23XX. I am sure this is the right way, because this way user has no option to disable common board (if he wants to use his own board initialization drivers) So, you will need to update all the board profiles using this command: ``` $ ./tools/refresh.sh --silent --defaults all ``` It will take some time, about 1 or 2h depending on your machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org