acassis commented on code in PR #16241:
URL: https://github.com/apache/nuttx/pull/16241#discussion_r2051796914
##########
tools/Unix.mk:
##########
@@ -753,6 +753,7 @@ savedefconfig: apps_preconfig
$(Q) grep "^CONFIG_ARCH_CHIP_" .config >> defconfig.tmp; true
$(Q) grep "CONFIG_ARCH_CHIP=" .config >> defconfig.tmp; true
$(Q) grep "CONFIG_ARCH_BOARD=" .config >> defconfig.tmp; true
+ $(Q) grep "CONFIG_ARCH_BOARD_COMMON=" .config >> defconfig.tmp; true
Review Comment:
@shtirlic maybe after you include the ARCH_BOARD_COMMON to the boards we
could remove the ARCH_BOARD_COMMON from "config ARCH_CHIP_RP23XX". We need to
align with original author about it. I think a chip definition shouldn't
include a board policy like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
