xiaoxiang781216 commented on code in PR #16194:
URL: https://github.com/apache/nuttx/pull/16194#discussion_r2056138290
##########
include/nuttx/mutex.h:
##########
@@ -36,10 +36,11 @@
* Pre-processor Definitions
****************************************************************************/
-#define NXMUTEX_NO_HOLDER ((pid_t)-1)
-#define NXMUTEX_INITIALIZER {NXSEM_INITIALIZER(1, SEM_TYPE_MUTEX | \
- SEM_PRIO_INHERIT), NXMUTEX_NO_HOLDER}
-#define NXRMUTEX_INITIALIZER {NXMUTEX_INITIALIZER, 0}
+#define NXMUTEX_INITIALIZER { \
+ NXSEM_INITIALIZER(NXMUTEX_NO_HOLDER, SEM_TYPE_MUTEX | SEM_PRIO_INHERIT), \
+ NXMUTEX_NO_HOLDER}
Review Comment:
can we add the cleanup patch into this pr?
##########
include/nuttx/semaphore.h:
##########
@@ -184,9 +184,17 @@ int nxsem_destroy(FAR sem_t *sem);
*
****************************************************************************/
-int nxsem_wait(FAR sem_t *sem);
int nxsem_wait_slow(FAR sem_t *sem);
+#if !defined(CONFIG_SMP) && defined(CONFIG_BUILD_FLAT)
+static inline int nxsem_wait(FAR sem_t *sem)
Review Comment:
do you make some benchmark? The fast path is still better even in flat/up
case from our test from our test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
