jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2056479486
########## include/nuttx/semaphore.h: ########## @@ -184,9 +184,17 @@ int nxsem_destroy(FAR sem_t *sem); * ****************************************************************************/ -int nxsem_wait(FAR sem_t *sem); int nxsem_wait_slow(FAR sem_t *sem); +#if !defined(CONFIG_SMP) && defined(CONFIG_BUILD_FLAT) +static inline int nxsem_wait(FAR sem_t *sem) Review Comment: I dropped this patch, this is a good discussion, but maybe not in context of this huge pr. IMHO, there should be a way to disable the fast paths and use of atomic RMW inside critical sections for non-smp builds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
