TimJTi opened a new pull request, #16257:
URL: https://github.com/apache/nuttx/pull/16257

   ## Summary
   
   This PR adds Kconfig-selected splashscreen options used when the driver is 
first registered
   
   * Includes a new Python script in ./tools to create RLE bitmap files
   * Includes default NS logo btimaps in 320x320, 160x160 and 80x80 resolutions 
along with their PNG files
   * Allows for out-of tree splashscreen files to be used instead
   
   ## Impact
   
   It should have no meaningful  impact as the options are selected from 
Kconfig, but the default *is* to enable the splashscreen since this has been 
requested by @acassis - but I can change that of course.
   
   ## Testing
   I have a custom board using a SAMA5D27C-D1G fitted with an 800x480 24 bit 
LCD. I have tested all the combinations of bitmap logo sizes as well as with an 
external file, in the 3 resolution configurations supported by NuttX for this 
processor and it seems to behave OK.
   
   ##Concerns
   
   1. To pass checkpatch.sh styling, the logo files are 10,000's lines long. I 
don't think I can do anything about that?
   2. To allow for an external, out-of-tree splashscreen file (which the Python 
script can handle) I am making the assumption that the necessary object file is 
created by the Users makefile/make.defs. If there's a better way to do this, 
let me know.
   3. I have never used Python until now so the script may not be the neatest 
or best - so any suggestions welcomed.
   4. I have added some error trapping for mismatches in logo sizes and LCD 
sizes, but it might be kind of nice to allow, say. an 8 bit greyscale logo to 
be used even on an RGB565 (or whatever) system - I might play with that more 
and push enhancements in I can get it to work.
   5. I have noticed that if you change NXlogo bitmap sizes (via Kconfig) it 
needs a `make clean` otherwise the results are not as expected. I don't know if 
that's inherent in NuttX or something I can force-fix via the Make.defs or some 
other means?
   
   Will leave as a draft to await input and while I do further testing along 
with enhancements I'm adding to NXboot to create an overall boot-up "package" 
that others can make use of and that I will document once the dust has settled.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to