jlaitine commented on code in PR #16194:
URL: https://github.com/apache/nuttx/pull/16194#discussion_r2065541572


##########
sched/semaphore/sem_post.c:
##########
@@ -156,7 +195,17 @@ int nxsem_post_slow(FAR sem_t *sem)
            * it is awakened.
            */
 
-          nxsem_add_holder_tcb(stcb, sem);
+          if (mutex)

Review Comment:
   No. The else path is for counting semaphores which may be posted before 
anyone has wated on them.  This is not true for mutexes. Whoever waited on the 
mutex has aready added the holder in sem_wait.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to