TimJTi commented on code in PR #3081: URL: https://github.com/apache/nuttx-apps/pull/3081#discussion_r2106157782
########## netutils/mdns/Kconfig: ########## @@ -0,0 +1,81 @@ +config LIB_MDNS + bool "MDNS library" + default n + ---help--- + Enable the mDNS library. This allows calls to the library to be made. + + This external library is "unlicensed" using the methodology from http://unlicense.org. + You should be sure that this license is acceptable for your usage. + + By default, the "built-in" demo is added as an application that can + ne run from nsh <mdns>. + + This is also needed for the optional daemon that allows the demo + app's mDNS functionality to be started and stopped from user + applications. There is an associated example app + (CONFIG_EXAMPLES_MDNSD) to allow the daemon to be tried from nsh. + + Ultimately, this should be used simply as a library, and neither the + demo app nor the daemon utilised. If just built as a library,the + relevant header file <mdns.h> is copied to the usual netutils + include location and can be utilised be including it: + + #include <netutils/mdns.h> + +if LIB_MDNS + +config NETUTILS_MDNS_DAEMON + tristate "Allows mdns to be run as a daemon and started/stopped" + default n + select NETUTILS_MDNS + ---help--- + The daemon wraps the mdns demo app as a daemon, so automatically + selects NETUTILS_MDNS + +if NETUTILS_MDNS_DAEMON + +config NETUTILS_MDNS_DAEMON_STOP_SIGNAL + int "Signal used to stop the MDNSD daemon" + default 22 + +endif + +config NETUTILS_MDNS + tristate "Enable mdns built-in demo app" + default n + ---help--- + Enable the author's original built-in MDNS demo app. This allows the + functionality of the library to be demonstrated. Information on using + it is available from the original git repo for this external library: + + https://github.com/mjansson/mdns + + There is also an example app (CONFIG_EXAMPLES_MDNSD) to allow the + mdns daemon to be tried via the NuttX shell. + +if NETUTILS_MDNS + +config NETUTILS_MDNS_PROGNAME + string "mDNS program name" + default "mdns" + ---help--- + This is the name of the program that will be used when the NSH ELF + program is installed. + +config NETUTILS_MDNS_PRIORITY + int "mDNS task priority" + default 100 + +config NETUTILS_MDNS_STACKSIZE + int "mDNS stack size" + default DEFAULT_TASK_STACKSIZE + ---help--- + The default (4KiB) is adequate for simple networks but this will + most likely need to be increased if there are many network devices + attached that could send queries. + +config NETUTILS_MDNS_VERBOSE Review Comment: Just to 100% check that you do mean `NETUTILS_MDNS_VERBOSE` in line 77? This is used in the patch script: ``` #if defined(MDNS_FUZZING) #define recvfrom(sock, buffer, capacity, flags, src_addr, addrlen) ((mdns_ssize_t)capacity) -#define printf +#endif +#if defined(MDNS_FUZZING) || !defined(CONFIG_NETUTILS_MDNS_VERBOSE) +#define printf(...) #endif ``` By the way - how do you quote the git changes with the + and -, in green, when you're reviewing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
