TimJTi commented on code in PR #3081:
URL: https://github.com/apache/nuttx-apps/pull/3081#discussion_r2111567567


##########
netutils/mdns/Kconfig:
##########
@@ -0,0 +1,81 @@
+config LIB_MDNS
+       bool "MDNS library"
+       default n
+       ---help---
+               Enable the mDNS library. This allows calls to the library to be 
made.
+               
+               This external library is "unlicensed" using the methodology 
from http://unlicense.org.
+               You should be sure that this license is acceptable for your 
usage.
+
+                By default, the "built-in" demo is added as an application 
that can
+                ne run from nsh <mdns>.
+                
+                This is also needed for the optional daemon that allows the 
demo
+                app's mDNS functionality to be started and stopped from user
+                applications. There is an associated example app
+                (CONFIG_EXAMPLES_MDNSD) to allow the daemon to be tried from 
nsh.
+
+                Ultimately, this should be used simply as a library, and 
neither the
+                demo app nor the daemon utilised. If just built as a 
library,the
+                relevant header file <mdns.h> is copied to the usual netutils
+                include location and can be utilised be including it:
+
+                #include <netutils/mdns.h>
+
+if LIB_MDNS
+
+config NETUTILS_MDNS_DAEMON
+        tristate "Allows mdns to be run as a daemon and started/stopped"
+        default n
+        select NETUTILS_MDNS
+        ---help---
+                The daemon wraps the mdns demo app as a daemon, so 
automatically
+                selects NETUTILS_MDNS
+
+if NETUTILS_MDNS_DAEMON

Review Comment:
   Done



##########
netutils/mdns/Kconfig:
##########
@@ -0,0 +1,81 @@
+config LIB_MDNS
+       bool "MDNS library"
+       default n
+       ---help---
+               Enable the mDNS library. This allows calls to the library to be 
made.
+               
+               This external library is "unlicensed" using the methodology 
from http://unlicense.org.
+               You should be sure that this license is acceptable for your 
usage.
+
+                By default, the "built-in" demo is added as an application 
that can
+                ne run from nsh <mdns>.
+                
+                This is also needed for the optional daemon that allows the 
demo
+                app's mDNS functionality to be started and stopped from user
+                applications. There is an associated example app
+                (CONFIG_EXAMPLES_MDNSD) to allow the daemon to be tried from 
nsh.
+
+                Ultimately, this should be used simply as a library, and 
neither the
+                demo app nor the daemon utilised. If just built as a 
library,the
+                relevant header file <mdns.h> is copied to the usual netutils
+                include location and can be utilised be including it:
+
+                #include <netutils/mdns.h>
+
+if LIB_MDNS
+
+config NETUTILS_MDNS_DAEMON
+        tristate "Allows mdns to be run as a daemon and started/stopped"
+        default n
+        select NETUTILS_MDNS

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to