linguini1 commented on code in PR #3090: URL: https://github.com/apache/nuttx-apps/pull/3090#discussion_r2135948297
########## system/syslogd/syslogd_main.c: ########## @@ -0,0 +1,291 @@ +/**************************************************************************** + * apps/system/syslogd/syslogd_main.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for asyslogditional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <errno.h> +#include <fcntl.h> +#include <stdbool.h> +#include <stdint.h> +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> + +#include <getopt.h> + +#include <arpa/inet.h> +#include <netinet/in.h> +#include <sys/socket.h> + +#include <syslog.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* Program name */ + +#define g_syslogd CONFIG_SYSTEM_SYSLOGD_PROGNAME + +/* syslogd program version */ + +#define SYSLOGD_VERSION "0.0.0" + +/* Minimum buffer size check */ + +#if CONFIG_SYSTEM_SYSLOGD_ENTRYSIZE < 480 +#error "SYSTEM_SYSLOGD_ENTRYSIZE must be more than 480 to satisfy RFC 5424" +#endif + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +bool g_debugmode = false; +bool g_background = true; +char g_buffer[CONFIG_SYSTEM_SYSLOGD_ENTRYSIZE]; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: print_usage + ****************************************************************************/ + +static void print_usage(void) +{ + fprintf(stderr, "usage:\n"); + fprintf(stderr, " %s [-vdn]\n", g_syslogd); +} + +/**************************************************************************** + * Name: read_log + * + * Description: + * Read a single log (end indicated by a newline character) into `buf`. + ****************************************************************************/ + +static ssize_t read_log(int fd, char *buf, size_t n) +{ + ssize_t count = 0; + ssize_t bread; + + while (count < n) + { + bread = read(fd, buf, 1); Review Comment: I agree, this was the simplest way I could think of scanning for a newline without relying on `fgets`. Do you think I should just read the whole buffer and mark where the newline starts by looping through after the read? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
