xiaoxiang781216 commented on code in PR #16496:
URL: https://github.com/apache/nuttx/pull/16496#discussion_r2136771345
##########
libs/libc/stream/lib_blkoutstream.c:
##########
@@ -239,18 +239,18 @@ void lib_blkoutstream_close(FAR struct lib_blkoutstream_s
*stream)
{
if (stream != NULL)
{
- if (stream->inode != NULL)
- {
- close_blockdriver(stream->inode);
- stream->inode = NULL;
- }
-
if (stream->cache != NULL)
{
blkoutstream_flush(&stream->common);
lib_free(stream->cache);
stream->cache = NULL;
}
+
+ if (stream->inode != NULL)
+ {
+ close_blockdriver(stream->inode);
+ stream->inode = NULL;
+ }
Review Comment:
> Please include comment message to this commit.
Done.
> What was the site effect before this patch? The last data in cache was
lost?
Yes, the data not flush is lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
