acassis commented on code in PR #16496:
URL: https://github.com/apache/nuttx/pull/16496#discussion_r2138422072


##########
libs/libc/stream/lib_mtdoutstream.c:
##########
@@ -342,18 +330,22 @@ int lib_mtdoutstream_open(FAR struct lib_mtdoutstream_s 
*stream,
       return -EINVAL;
     }
 
-  stream->cache = lib_malloc(stream->geo.erasesize);
-  if (stream->cache == NULL)
+#ifdef CONFIG_MTD_BYTE_WRITE

Review Comment:
   Please include a comment here, to explain the case of MTD_BYTE_WRITE enable 
and the case it is not enabled. It will help people to understand the goal of 
this part of the code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to