patacongo commented on PR #16544: URL: https://github.com/apache/nuttx/pull/16544#issuecomment-2983860996
The 's' indicates that the output is a string data. For those that generate strings on output, the 's' is correct and in some sense required. The 's' should not appear if strings are not generated. ________________________________ From: CeDeROM ***@***.***> Sent: Wednesday, June 18, 2025 4:27 AM To: apache/nuttx ***@***.***> Cc: patacongo ***@***.***>; Review requested ***@***.***> Subject: Re: [apache/nuttx] libc/stream: Rename lib_xsprintfyyy to lib_xprintfyyy (PR #16544) @cederom commented on this pull request. ________________________________ In libs/libc/stream/lib_libbsprintf.c<https://github.com/apache/nuttx/pull/16544#discussion_r2154358662>: > } - ret += lib_sprintf(s, fmtstr, value); + ret += lib_sprintf(s, fmtstr, var->s); This seems okay since var = (FAR void *)(data + offset); is calculated already on line 89 :-) Why temporary const char * was used here maybe some compilers complained? But fmtstr also should be const char * while its not :-) — Reply to this email directly, view it on GitHub<https://github.com/apache/nuttx/pull/16544#pullrequestreview-2938829790>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABFUG6RRHS6ATTGFFUAECU33EFELFAVCNFSM6AAAAAB7RW5LQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZYHAZDSNZZGA>. You are receiving this because your review was requested.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
