cederom commented on PR #16544: URL: https://github.com/apache/nuttx/pull/16544#issuecomment-2984754978
Thank you @xiaoxiang781216 for the details and splitting the PR, I have already accepted changes (1) and (2) in the separate PR (https://github.com/apache/nuttx/pull/16549) :-) Regarding the function calls rename I would stick to existing implementation of `sprintf()` in place of new `printf()` even for the internal representation when the first parameter is `stream` not `format` to be more coherent with their standard/external versions of the calls. One clear disadvantage of this move is breaking compatibility between nuttx and nuttx-apps in some places affected by the change (i.e. older nuttx-apps will not build on newer nuttx and vice versa, that touches gcov and uorb see https://github.com/apache/nuttx-apps/pull/3100). But I will align to the decision of the community :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
