PetervdPerk-NXP commented on code in PR #16743: URL: https://github.com/apache/nuttx/pull/16743#discussion_r2215790219
########## arch/arm64/src/imx9/Make.defs: ########## @@ -28,13 +28,16 @@ endif # i.MX9-specific C source files -CHIP_CSRCS = imx9_boot.c imx9_ccm.c imx9_clockconfig.c imx9_gpio.c -CHIP_CSRCS += imx9_iomuxc.c imx9_timer.c +CHIP_CSRCS = imx9_boot.c imx9_timer.c -ifeq ($(CONFIG_ARCH_CHIP_IMX93),y) - CHIP_CSRCS += imx9_lpuart.c imx9_lowputc.c +ifeq ($(CONFIG_IMX95_BOOTL_FROM_LINUX),n) Review Comment: Can we avoid using this `CONFIG_IMX95_BOOTL_FROM_LINUX` macro. It makes the code unreadable and it's quite a niche try to foucs on `CONFIG_ARCH_CHIP_IMX93` `CONFIG_ARCH_CHIP_IMX95` And then in some cases use the `CONFIG_IMX95_BOOTL_FROM_LINUX` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org