tmedicci commented on code in PR #16756:
URL: https://github.com/apache/nuttx/pull/16756#discussion_r2228649111
##########
arch/xtensa/src/esp32s3/Kconfig:
##########
@@ -1090,9 +1090,12 @@ choice ESP32S3_SPIRAM_HEAP
config ESP32S3_SPIRAM_COMMON_HEAP
bool "Additional region to kernel heap"
+ depends on !ESP32S3_SPIFLASH && !ESPRESSIF_WIFI && !BUILD_PROTECTED
Review Comment:
It would probably be a workaround (I'll test later), but
`CONFIG_XTENSA_IMEM_USE_SEPARATE_HEAP` is something that could be deprecated
for ESP32-S3. It "reserves" part of the internal memory that could be used by
other kernel tasks and requires a different API for allocating/deallocating it,
whilst `CONFIG_MM_KERNEL_HEAP` is part of the NuttX's memory manager. I'd stick
with kernel/user heap separation in this case and remove
`CONFIG_XTENSA_IMEM_USE_SEPARATE_HEAP` for ESP32-S3 in the future. Please note
that for ESP32-S3 there are no limitations on accessing PSRAM's through the
instruction bus (something that is true for ESP32). Please check
https://github.com/apache/nuttx/pull/16756#issuecomment-3113617106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
