yamt commented on PR #16756:
URL: https://github.com/apache/nuttx/pull/16756#issuecomment-3116293490

   > > > please let me test a bit.
   > > 
   > > 
   > > this breaks my configuration.
   > > my configuration assumes spiram is available for text heap. (for wamr) 
the configuration also uses wifi. as text heap for esp32s3 is currently [backed 
by 
kmm](https://github.com/apache/nuttx/blob/cbd033ae90981bf49ca3804a5502bf6ce60ed2cf/arch/xtensa/src/esp32s3/esp32s3_textheap.c#L90),
 kmm separation forced by this PR for wifi breaks it.
   > > (the configuration also happens to use spiflash, which was just working 
by luck i guess. maybe because LPWORK stack is allocated early in the boot. 
maybe it helps to have a debug option to make the malloc pick memory regions in 
an unusual order.)
   > 
   > Can you apply the following diff and re-test your config?
   > 
   > ```
   > diff --git a/arch/xtensa/src/esp32s3/esp32s3_textheap.c 
b/arch/xtensa/src/esp32s3/esp32s3_textheap.c
   > index a0695200f7..1ebcb57f90 100644
   > --- a/arch/xtensa/src/esp32s3/esp32s3_textheap.c
   > +++ b/arch/xtensa/src/esp32s3/esp32s3_textheap.c
   > @@ -87,7 +87,7 @@ void *up_textheap_memalign(size_t align, size_t size)
   >  
   >    if (ret == NULL)
   >      {
   > -      ret = kmm_memalign(align, size);
   > +      ret = memalign(align, size);
   >        if (ret)
   >          {
   >            /* kmm_memalign buffer is at the Data bus offset.  Adjust it so 
we
   > ```
   
   this approach might work for my config. but i suspect it can break others.
   note that text heap api is used for the kernel stuff as well. (mod_insmod.c)
   i suspect it needs an api tweak for kmem/umem separation.
   
   > If not successful, can you please share (part of it, if preferable) your 
config?
   
   i provide a full config here anyway. it isn't a secret. (ignore mbedtls and 
jsonsink stuff. they are wip.)
   [16756.zip](https://github.com/user-attachments/files/21422543/16756.zip)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to