xiaoxiang781216 commented on code in PR #16812:
URL: https://github.com/apache/nuttx/pull/16812#discussion_r2255732862
##########
arch/arm/src/imxrt/imxrt_ehci.c:
##########
@@ -459,8 +459,8 @@ static int imxrt_qh_dump(struct imxrt_qh_s *qh, uint32_t
**bp, void *arg);
#else
# define imxrt_qtd_print(qtd)
# define imxrt_qh_print(qh)
-# define imxrt_qtd_dump(qtd, bp, arg) OK
-# define imxrt_qh_dump(qh, bp, arg) OK
+# define imxrt_qtd_dump(qtd, bp, arg) ((void) OK)
Review Comment:
remove space before OK
##########
boards/arm/imxrt/arcx-socket-grid/src/arcx-socket-grid.h:
##########
@@ -71,10 +71,14 @@
#define GPIO_GOUT4 (GPIO_OUTPUT | GPIO_OUTPUT_ZERO | IOMUX_GOUT_DEFAULT |
\
GPIO_PIN9 | GPIO_PORT1)
-/* Backlight */
+/* USB OTG1 ID Pin： GPIO_AD_B0_01 */
-#define GPIO_LCD_BL (GPIO_OUTPUT | GPIO_OUTPUT_ZERO | GPIO_PORT2 | \
- GPIO_PIN31 | IOMUX_LCD_BL_DEFAULT)
+#define GPIO_USBOTG1_ID (GPIO_USB_OTG1_ID_2 | IOMUX_USBOTG_ID_DEFAULT)
/* AD_B0_01 */
Review Comment:
remove extra space to align with line 71
##########
boards/arm/imxrt/arcx-socket-grid/src/arcx-socket-grid.h:
##########
@@ -71,10 +71,14 @@
#define GPIO_GOUT4 (GPIO_OUTPUT | GPIO_OUTPUT_ZERO | IOMUX_GOUT_DEFAULT |
\
GPIO_PIN9 | GPIO_PORT1)
-/* Backlight */
+/* USB OTG1 ID Pin： GPIO_AD_B0_01 */
-#define GPIO_LCD_BL (GPIO_OUTPUT | GPIO_OUTPUT_ZERO | GPIO_PORT2 | \
- GPIO_PIN31 | IOMUX_LCD_BL_DEFAULT)
+#define GPIO_USBOTG1_ID (GPIO_USB_OTG1_ID_2 | IOMUX_USBOTG_ID_DEFAULT)
/* AD_B0_01 */
+
+/* USB HOST Power - GPIO_B1_15 */
+
+#define USB_HOST_PWR (GPIO_OUTPUT | GPIO_OUTPUT_ZERO | GPIO_PORT2 | \
Review Comment:
remove extra spaces to align with line 71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
